1 2- general code review and cleanup 3- can this be converted to not require PCI_DRIVERS_LEGACY ?? 4 The irq returned by pcibios_map_irq is a "hwirq" (hardware irq number) 5 and pci_assign_irq() assigns this directly to dev->irq, which 6 expects a "virq" (virtual irq number). These numbers are different 7 on MIPS. There is a gross hack to make it work on one 8 specific platform, so it can be tested. 9- Should this be merged with arch/mips/pci/pci-mt7620.c ?? 10- ensure device-tree requirements are documented 11 12Cc: NeilBrown <neil@brown.name> 13