1 2 How To Write Linux PCI Drivers 3 4 by Martin Mares <mj@ucw.cz> on 07-Feb-2000 5 updated by Grant Grundler <grundler@parisc-linux.org> on 23-Dec-2006 6 7~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 8The world of PCI is vast and full of (mostly unpleasant) surprises. 9Since each CPU architecture implements different chip-sets and PCI devices 10have different requirements (erm, "features"), the result is the PCI support 11in the Linux kernel is not as trivial as one would wish. This short paper 12tries to introduce all potential driver authors to Linux APIs for 13PCI device drivers. 14 15A more complete resource is the third edition of "Linux Device Drivers" 16by Jonathan Corbet, Alessandro Rubini, and Greg Kroah-Hartman. 17LDD3 is available for free (under Creative Commons License) from: 18 19 http://lwn.net/Kernel/LDD3/ 20 21However, keep in mind that all documents are subject to "bit rot". 22Refer to the source code if things are not working as described here. 23 24Please send questions/comments/patches about Linux PCI API to the 25"Linux PCI" <linux-pci@atrey.karlin.mff.cuni.cz> mailing list. 26 27 28 290. Structure of PCI drivers 30~~~~~~~~~~~~~~~~~~~~~~~~~~~ 31PCI drivers "discover" PCI devices in a system via pci_register_driver(). 32Actually, it's the other way around. When the PCI generic code discovers 33a new device, the driver with a matching "description" will be notified. 34Details on this below. 35 36pci_register_driver() leaves most of the probing for devices to 37the PCI layer and supports online insertion/removal of devices [thus 38supporting hot-pluggable PCI, CardBus, and Express-Card in a single driver]. 39pci_register_driver() call requires passing in a table of function 40pointers and thus dictates the high level structure of a driver. 41 42Once the driver knows about a PCI device and takes ownership, the 43driver generally needs to perform the following initialization: 44 45 Enable the device 46 Request MMIO/IOP resources 47 Set the DMA mask size (for both coherent and streaming DMA) 48 Allocate and initialize shared control data (pci_allocate_coherent()) 49 Access device configuration space (if needed) 50 Register IRQ handler (request_irq()) 51 Initialize non-PCI (i.e. LAN/SCSI/etc parts of the chip) 52 Enable DMA/processing engines 53 54When done using the device, and perhaps the module needs to be unloaded, 55the driver needs to take the follow steps: 56 Disable the device from generating IRQs 57 Release the IRQ (free_irq()) 58 Stop all DMA activity 59 Release DMA buffers (both streaming and coherent) 60 Unregister from other subsystems (e.g. scsi or netdev) 61 Release MMIO/IOP resources 62 Disable the device 63 64Most of these topics are covered in the following sections. 65For the rest look at LDD3 or <linux/pci.h> . 66 67If the PCI subsystem is not configured (CONFIG_PCI is not set), most of 68the PCI functions described below are defined as inline functions either 69completely empty or just returning an appropriate error codes to avoid 70lots of ifdefs in the drivers. 71 72 73 741. pci_register_driver() call 75~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 76 77PCI device drivers call pci_register_driver() during their 78initialization with a pointer to a structure describing the driver 79(struct pci_driver): 80 81 field name Description 82 ---------- ------------------------------------------------------ 83 id_table Pointer to table of device ID's the driver is 84 interested in. Most drivers should export this 85 table using MODULE_DEVICE_TABLE(pci,...). 86 87 probe This probing function gets called (during execution 88 of pci_register_driver() for already existing 89 devices or later if a new device gets inserted) for 90 all PCI devices which match the ID table and are not 91 "owned" by the other drivers yet. This function gets 92 passed a "struct pci_dev *" for each device whose 93 entry in the ID table matches the device. The probe 94 function returns zero when the driver chooses to 95 take "ownership" of the device or an error code 96 (negative number) otherwise. 97 The probe function always gets called from process 98 context, so it can sleep. 99 100 remove The remove() function gets called whenever a device 101 being handled by this driver is removed (either during 102 deregistration of the driver or when it's manually 103 pulled out of a hot-pluggable slot). 104 The remove function always gets called from process 105 context, so it can sleep. 106 107 suspend Put device into low power state. 108 suspend_late Put device into low power state. 109 110 resume_early Wake device from low power state. 111 resume Wake device from low power state. 112 113 (Please see Documentation/power/pci.txt for descriptions 114 of PCI Power Management and the related functions.) 115 116 shutdown Hook into reboot_notifier_list (kernel/sys.c). 117 Intended to stop any idling DMA operations. 118 Useful for enabling wake-on-lan (NIC) or changing 119 the power state of a device before reboot. 120 e.g. drivers/net/e100.c. 121 122 err_handler See Documentation/PCI/pci-error-recovery.txt 123 124 125The ID table is an array of struct pci_device_id entries ending with an 126all-zero entry. Definitions with static const are generally preferred. 127 128Each entry consists of: 129 130 vendor,device Vendor and device ID to match (or PCI_ANY_ID) 131 132 subvendor, Subsystem vendor and device ID to match (or PCI_ANY_ID) 133 subdevice, 134 135 class Device class, subclass, and "interface" to match. 136 See Appendix D of the PCI Local Bus Spec or 137 include/linux/pci_ids.h for a full list of classes. 138 Most drivers do not need to specify class/class_mask 139 as vendor/device is normally sufficient. 140 141 class_mask limit which sub-fields of the class field are compared. 142 See drivers/scsi/sym53c8xx_2/ for example of usage. 143 144 driver_data Data private to the driver. 145 Most drivers don't need to use driver_data field. 146 Best practice is to use driver_data as an index 147 into a static list of equivalent device types, 148 instead of using it as a pointer. 149 150 151Most drivers only need PCI_DEVICE() or PCI_DEVICE_CLASS() to set up 152a pci_device_id table. 153 154New PCI IDs may be added to a device driver pci_ids table at runtime 155as shown below: 156 157echo "vendor device subvendor subdevice class class_mask driver_data" > \ 158/sys/bus/pci/drivers/{driver}/new_id 159 160All fields are passed in as hexadecimal values (no leading 0x). 161The vendor and device fields are mandatory, the others are optional. Users 162need pass only as many optional fields as necessary: 163 o subvendor and subdevice fields default to PCI_ANY_ID (FFFFFFFF) 164 o class and classmask fields default to 0 165 o driver_data defaults to 0UL. 166 167Note that driver_data must match the value used by any of the pci_device_id 168entries defined in the driver. This makes the driver_data field mandatory 169if all the pci_device_id entries have a non-zero driver_data value. 170 171Once added, the driver probe routine will be invoked for any unclaimed 172PCI devices listed in its (newly updated) pci_ids list. 173 174When the driver exits, it just calls pci_unregister_driver() and the PCI layer 175automatically calls the remove hook for all devices handled by the driver. 176 177 1781.1 "Attributes" for driver functions/data 179 180Please mark the initialization and cleanup functions where appropriate 181(the corresponding macros are defined in <linux/init.h>): 182 183 __init Initialization code. Thrown away after the driver 184 initializes. 185 __exit Exit code. Ignored for non-modular drivers. 186 187Tips on when/where to use the above attributes: 188 o The module_init()/module_exit() functions (and all 189 initialization functions called _only_ from these) 190 should be marked __init/__exit. 191 192 o Do not mark the struct pci_driver. 193 194 o Do NOT mark a function if you are not sure which mark to use. 195 Better to not mark the function than mark the function wrong. 196 197 198 1992. How to find PCI devices manually 200~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 201 202PCI drivers should have a really good reason for not using the 203pci_register_driver() interface to search for PCI devices. 204The main reason PCI devices are controlled by multiple drivers 205is because one PCI device implements several different HW services. 206E.g. combined serial/parallel port/floppy controller. 207 208A manual search may be performed using the following constructs: 209 210Searching by vendor and device ID: 211 212 struct pci_dev *dev = NULL; 213 while (dev = pci_get_device(VENDOR_ID, DEVICE_ID, dev)) 214 configure_device(dev); 215 216Searching by class ID (iterate in a similar way): 217 218 pci_get_class(CLASS_ID, dev) 219 220Searching by both vendor/device and subsystem vendor/device ID: 221 222 pci_get_subsys(VENDOR_ID,DEVICE_ID, SUBSYS_VENDOR_ID, SUBSYS_DEVICE_ID, dev). 223 224You can use the constant PCI_ANY_ID as a wildcard replacement for 225VENDOR_ID or DEVICE_ID. This allows searching for any device from a 226specific vendor, for example. 227 228These functions are hotplug-safe. They increment the reference count on 229the pci_dev that they return. You must eventually (possibly at module unload) 230decrement the reference count on these devices by calling pci_dev_put(). 231 232 233 2343. Device Initialization Steps 235~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 236 237As noted in the introduction, most PCI drivers need the following steps 238for device initialization: 239 240 Enable the device 241 Request MMIO/IOP resources 242 Set the DMA mask size (for both coherent and streaming DMA) 243 Allocate and initialize shared control data (pci_allocate_coherent()) 244 Access device configuration space (if needed) 245 Register IRQ handler (request_irq()) 246 Initialize non-PCI (i.e. LAN/SCSI/etc parts of the chip) 247 Enable DMA/processing engines. 248 249The driver can access PCI config space registers at any time. 250(Well, almost. When running BIST, config space can go away...but 251that will just result in a PCI Bus Master Abort and config reads 252will return garbage). 253 254 2553.1 Enable the PCI device 256~~~~~~~~~~~~~~~~~~~~~~~~~ 257Before touching any device registers, the driver needs to enable 258the PCI device by calling pci_enable_device(). This will: 259 o wake up the device if it was in suspended state, 260 o allocate I/O and memory regions of the device (if BIOS did not), 261 o allocate an IRQ (if BIOS did not). 262 263NOTE: pci_enable_device() can fail! Check the return value. 264 265[ OS BUG: we don't check resource allocations before enabling those 266 resources. The sequence would make more sense if we called 267 pci_request_resources() before calling pci_enable_device(). 268 Currently, the device drivers can't detect the bug when when two 269 devices have been allocated the same range. This is not a common 270 problem and unlikely to get fixed soon. 271 272 This has been discussed before but not changed as of 2.6.19: 273 http://lkml.org/lkml/2006/3/2/194 274] 275 276pci_set_master() will enable DMA by setting the bus master bit 277in the PCI_COMMAND register. It also fixes the latency timer value if 278it's set to something bogus by the BIOS. pci_clear_master() will 279disable DMA by clearing the bus master bit. 280 281If the PCI device can use the PCI Memory-Write-Invalidate transaction, 282call pci_set_mwi(). This enables the PCI_COMMAND bit for Mem-Wr-Inval 283and also ensures that the cache line size register is set correctly. 284Check the return value of pci_set_mwi() as not all architectures 285or chip-sets may support Memory-Write-Invalidate. Alternatively, 286if Mem-Wr-Inval would be nice to have but is not required, call 287pci_try_set_mwi() to have the system do its best effort at enabling 288Mem-Wr-Inval. 289 290 2913.2 Request MMIO/IOP resources 292~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 293Memory (MMIO), and I/O port addresses should NOT be read directly 294from the PCI device config space. Use the values in the pci_dev structure 295as the PCI "bus address" might have been remapped to a "host physical" 296address by the arch/chip-set specific kernel support. 297 298See Documentation/io-mapping.txt for how to access device registers 299or device memory. 300 301The device driver needs to call pci_request_region() to verify 302no other device is already using the same address resource. 303Conversely, drivers should call pci_release_region() AFTER 304calling pci_disable_device(). 305The idea is to prevent two devices colliding on the same address range. 306 307[ See OS BUG comment above. Currently (2.6.19), The driver can only 308 determine MMIO and IO Port resource availability _after_ calling 309 pci_enable_device(). ] 310 311Generic flavors of pci_request_region() are request_mem_region() 312(for MMIO ranges) and request_region() (for IO Port ranges). 313Use these for address resources that are not described by "normal" PCI 314BARs. 315 316Also see pci_request_selected_regions() below. 317 318 3193.3 Set the DMA mask size 320~~~~~~~~~~~~~~~~~~~~~~~~~ 321[ If anything below doesn't make sense, please refer to 322 Documentation/DMA-API.txt. This section is just a reminder that 323 drivers need to indicate DMA capabilities of the device and is not 324 an authoritative source for DMA interfaces. ] 325 326While all drivers should explicitly indicate the DMA capability 327(e.g. 32 or 64 bit) of the PCI bus master, devices with more than 32832-bit bus master capability for streaming data need the driver 329to "register" this capability by calling pci_set_dma_mask() with 330appropriate parameters. In general this allows more efficient DMA 331on systems where System RAM exists above 4G _physical_ address. 332 333Drivers for all PCI-X and PCIe compliant devices must call 334pci_set_dma_mask() as they are 64-bit DMA devices. 335 336Similarly, drivers must also "register" this capability if the device 337can directly address "consistent memory" in System RAM above 4G physical 338address by calling pci_set_consistent_dma_mask(). 339Again, this includes drivers for all PCI-X and PCIe compliant devices. 340Many 64-bit "PCI" devices (before PCI-X) and some PCI-X devices are 34164-bit DMA capable for payload ("streaming") data but not control 342("consistent") data. 343 344 3453.4 Setup shared control data 346~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 347Once the DMA masks are set, the driver can allocate "consistent" (a.k.a. shared) 348memory. See Documentation/DMA-API.txt for a full description of 349the DMA APIs. This section is just a reminder that it needs to be done 350before enabling DMA on the device. 351 352 3533.5 Initialize device registers 354~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 355Some drivers will need specific "capability" fields programmed 356or other "vendor specific" register initialized or reset. 357E.g. clearing pending interrupts. 358 359 3603.6 Register IRQ handler 361~~~~~~~~~~~~~~~~~~~~~~~~ 362While calling request_irq() is the last step described here, 363this is often just another intermediate step to initialize a device. 364This step can often be deferred until the device is opened for use. 365 366All interrupt handlers for IRQ lines should be registered with IRQF_SHARED 367and use the devid to map IRQs to devices (remember that all PCI IRQ lines 368can be shared). 369 370request_irq() will associate an interrupt handler and device handle 371with an interrupt number. Historically interrupt numbers represent 372IRQ lines which run from the PCI device to the Interrupt controller. 373With MSI and MSI-X (more below) the interrupt number is a CPU "vector". 374 375request_irq() also enables the interrupt. Make sure the device is 376quiesced and does not have any interrupts pending before registering 377the interrupt handler. 378 379MSI and MSI-X are PCI capabilities. Both are "Message Signaled Interrupts" 380which deliver interrupts to the CPU via a DMA write to a Local APIC. 381The fundamental difference between MSI and MSI-X is how multiple 382"vectors" get allocated. MSI requires contiguous blocks of vectors 383while MSI-X can allocate several individual ones. 384 385MSI capability can be enabled by calling pci_alloc_irq_vectors() with the 386PCI_IRQ_MSI and/or PCI_IRQ_MSIX flags before calling request_irq(). This 387causes the PCI support to program CPU vector data into the PCI device 388capability registers. Many architectures, chip-sets, or BIOSes do NOT 389support MSI or MSI-X and a call to pci_alloc_irq_vectors with just 390the PCI_IRQ_MSI and PCI_IRQ_MSIX flags will fail, so try to always 391specify PCI_IRQ_LEGACY as well. 392 393Drivers that have different interrupt handlers for MSI/MSI-X and 394legacy INTx should chose the right one based on the msi_enabled 395and msix_enabled flags in the pci_dev structure after calling 396pci_alloc_irq_vectors. 397 398There are (at least) two really good reasons for using MSI: 3991) MSI is an exclusive interrupt vector by definition. 400 This means the interrupt handler doesn't have to verify 401 its device caused the interrupt. 402 4032) MSI avoids DMA/IRQ race conditions. DMA to host memory is guaranteed 404 to be visible to the host CPU(s) when the MSI is delivered. This 405 is important for both data coherency and avoiding stale control data. 406 This guarantee allows the driver to omit MMIO reads to flush 407 the DMA stream. 408 409See drivers/infiniband/hw/mthca/ or drivers/net/tg3.c for examples 410of MSI/MSI-X usage. 411 412 413 4144. PCI device shutdown 415~~~~~~~~~~~~~~~~~~~~~~~ 416 417When a PCI device driver is being unloaded, most of the following 418steps need to be performed: 419 420 Disable the device from generating IRQs 421 Release the IRQ (free_irq()) 422 Stop all DMA activity 423 Release DMA buffers (both streaming and consistent) 424 Unregister from other subsystems (e.g. scsi or netdev) 425 Disable device from responding to MMIO/IO Port addresses 426 Release MMIO/IO Port resource(s) 427 428 4294.1 Stop IRQs on the device 430~~~~~~~~~~~~~~~~~~~~~~~~~~~ 431How to do this is chip/device specific. If it's not done, it opens 432the possibility of a "screaming interrupt" if (and only if) 433the IRQ is shared with another device. 434 435When the shared IRQ handler is "unhooked", the remaining devices 436using the same IRQ line will still need the IRQ enabled. Thus if the 437"unhooked" device asserts IRQ line, the system will respond assuming 438it was one of the remaining devices asserted the IRQ line. Since none 439of the other devices will handle the IRQ, the system will "hang" until 440it decides the IRQ isn't going to get handled and masks the IRQ (100,000 441iterations later). Once the shared IRQ is masked, the remaining devices 442will stop functioning properly. Not a nice situation. 443 444This is another reason to use MSI or MSI-X if it's available. 445MSI and MSI-X are defined to be exclusive interrupts and thus 446are not susceptible to the "screaming interrupt" problem. 447 448 4494.2 Release the IRQ 450~~~~~~~~~~~~~~~~~~~ 451Once the device is quiesced (no more IRQs), one can call free_irq(). 452This function will return control once any pending IRQs are handled, 453"unhook" the drivers IRQ handler from that IRQ, and finally release 454the IRQ if no one else is using it. 455 456 4574.3 Stop all DMA activity 458~~~~~~~~~~~~~~~~~~~~~~~~~ 459It's extremely important to stop all DMA operations BEFORE attempting 460to deallocate DMA control data. Failure to do so can result in memory 461corruption, hangs, and on some chip-sets a hard crash. 462 463Stopping DMA after stopping the IRQs can avoid races where the 464IRQ handler might restart DMA engines. 465 466While this step sounds obvious and trivial, several "mature" drivers 467didn't get this step right in the past. 468 469 4704.4 Release DMA buffers 471~~~~~~~~~~~~~~~~~~~~~~~ 472Once DMA is stopped, clean up streaming DMA first. 473I.e. unmap data buffers and return buffers to "upstream" 474owners if there is one. 475 476Then clean up "consistent" buffers which contain the control data. 477 478See Documentation/DMA-API.txt for details on unmapping interfaces. 479 480 4814.5 Unregister from other subsystems 482~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 483Most low level PCI device drivers support some other subsystem 484like USB, ALSA, SCSI, NetDev, Infiniband, etc. Make sure your 485driver isn't losing resources from that other subsystem. 486If this happens, typically the symptom is an Oops (panic) when 487the subsystem attempts to call into a driver that has been unloaded. 488 489 4904.6 Disable Device from responding to MMIO/IO Port addresses 491~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 492io_unmap() MMIO or IO Port resources and then call pci_disable_device(). 493This is the symmetric opposite of pci_enable_device(). 494Do not access device registers after calling pci_disable_device(). 495 496 4974.7 Release MMIO/IO Port Resource(s) 498~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 499Call pci_release_region() to mark the MMIO or IO Port range as available. 500Failure to do so usually results in the inability to reload the driver. 501 502 503 5045. How to access PCI config space 505~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 506 507You can use pci_(read|write)_config_(byte|word|dword) to access the config 508space of a device represented by struct pci_dev *. All these functions return 0 509when successful or an error code (PCIBIOS_...) which can be translated to a text 510string by pcibios_strerror. Most drivers expect that accesses to valid PCI 511devices don't fail. 512 513If you don't have a struct pci_dev available, you can call 514pci_bus_(read|write)_config_(byte|word|dword) to access a given device 515and function on that bus. 516 517If you access fields in the standard portion of the config header, please 518use symbolic names of locations and bits declared in <linux/pci.h>. 519 520If you need to access Extended PCI Capability registers, just call 521pci_find_capability() for the particular capability and it will find the 522corresponding register block for you. 523 524 525 5266. Other interesting functions 527~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 528 529pci_get_domain_bus_and_slot() Find pci_dev corresponding to given domain, 530 bus and slot and number. If the device is 531 found, its reference count is increased. 532pci_set_power_state() Set PCI Power Management state (0=D0 ... 3=D3) 533pci_find_capability() Find specified capability in device's capability 534 list. 535pci_resource_start() Returns bus start address for a given PCI region 536pci_resource_end() Returns bus end address for a given PCI region 537pci_resource_len() Returns the byte length of a PCI region 538pci_set_drvdata() Set private driver data pointer for a pci_dev 539pci_get_drvdata() Return private driver data pointer for a pci_dev 540pci_set_mwi() Enable Memory-Write-Invalidate transactions. 541pci_clear_mwi() Disable Memory-Write-Invalidate transactions. 542 543 544 5457. Miscellaneous hints 546~~~~~~~~~~~~~~~~~~~~~~ 547 548When displaying PCI device names to the user (for example when a driver wants 549to tell the user what card has it found), please use pci_name(pci_dev). 550 551Always refer to the PCI devices by a pointer to the pci_dev structure. 552All PCI layer functions use this identification and it's the only 553reasonable one. Don't use bus/slot/function numbers except for very 554special purposes -- on systems with multiple primary buses their semantics 555can be pretty complex. 556 557Don't try to turn on Fast Back to Back writes in your driver. All devices 558on the bus need to be capable of doing it, so this is something which needs 559to be handled by platform and generic code, not individual drivers. 560 561 562 5638. Vendor and device identifications 564~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 565 566Do not add new device or vendor IDs to include/linux/pci_ids.h unless they 567are shared across multiple drivers. You can add private definitions in 568your driver if they're helpful, or just use plain hex constants. 569 570The device IDs are arbitrary hex numbers (vendor controlled) and normally used 571only in a single location, the pci_device_id table. 572 573Please DO submit new vendor/device IDs to http://pci-ids.ucw.cz/. 574There are mirrors of the pci.ids file at http://pciids.sourceforge.net/ 575and https://github.com/pciutils/pciids. 576 577 578 5799. Obsolete functions 580~~~~~~~~~~~~~~~~~~~~~ 581 582There are several functions which you might come across when trying to 583port an old driver to the new PCI interface. They are no longer present 584in the kernel as they aren't compatible with hotplug or PCI domains or 585having sane locking. 586 587pci_find_device() Superseded by pci_get_device() 588pci_find_subsys() Superseded by pci_get_subsys() 589pci_find_slot() Superseded by pci_get_domain_bus_and_slot() 590pci_get_slot() Superseded by pci_get_domain_bus_and_slot() 591 592 593The alternative is the traditional PCI device driver that walks PCI 594device lists. This is still possible but discouraged. 595 596 597 59810. MMIO Space and "Write Posting" 599~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 600 601Converting a driver from using I/O Port space to using MMIO space 602often requires some additional changes. Specifically, "write posting" 603needs to be handled. Many drivers (e.g. tg3, acenic, sym53c8xx_2) 604already do this. I/O Port space guarantees write transactions reach the PCI 605device before the CPU can continue. Writes to MMIO space allow the CPU 606to continue before the transaction reaches the PCI device. HW weenies 607call this "Write Posting" because the write completion is "posted" to 608the CPU before the transaction has reached its destination. 609 610Thus, timing sensitive code should add readl() where the CPU is 611expected to wait before doing other work. The classic "bit banging" 612sequence works fine for I/O Port space: 613 614 for (i = 8; --i; val >>= 1) { 615 outb(val & 1, ioport_reg); /* write bit */ 616 udelay(10); 617 } 618 619The same sequence for MMIO space should be: 620 621 for (i = 8; --i; val >>= 1) { 622 writeb(val & 1, mmio_reg); /* write bit */ 623 readb(safe_mmio_reg); /* flush posted write */ 624 udelay(10); 625 } 626 627It is important that "safe_mmio_reg" not have any side effects that 628interferes with the correct operation of the device. 629 630Another case to watch out for is when resetting a PCI device. Use PCI 631Configuration space reads to flush the writel(). This will gracefully 632handle the PCI master abort on all platforms if the PCI device is 633expected to not respond to a readl(). Most x86 platforms will allow 634MMIO reads to master abort (a.k.a. "Soft Fail") and return garbage 635(e.g. ~0). But many RISC platforms will crash (a.k.a."Hard Fail"). 636 637