add si32 HAL #29

M1cha · 2023-05-13T06:34:02Z

Source: precision32-development-environment-offline.exe
sha512: 6bccef30995da803985fcdfa4065c45e00e0eeefc300d61b7215926a97997dc8ce45078ffeb349602340759650f30aeccf3b1aa50086c61edc2426d016063cae
Website: https://www.silabs.com/developers/precision32-32-bit-microcontroller-development-suite?tab=downloads

rettichschnidi · 2023-05-13T08:10:16Z

si32/README

+   v1.1.2
+
+Purpose:
+   Add support for Silican Labs sim3u1xx SoCs


Suggested change

Add support for Silican Labs sim3u1xx SoCs

Add support for Silican Labs SiM3U1xx SoCs

rettichschnidi · 2023-05-13T08:10:27Z

si32/README

+   Add support for Silican Labs sim3u1xx SoCs
+
+Description:
+   This code component is used to add Zephyr support for Silicon Labs sim3u1xx SoCs.


Suggested change

This code component is used to add Zephyr support for Silicon Labs sim3u1xx SoCs.

This code component is used to add Zephyr support for Silicon Labs SiM3U1xx SoCs.

rettichschnidi · 2023-05-13T08:14:28Z

si32/README

+
+   The SDK contains an incompatible, proprietary license in `Documentation/Silabs_License_Agreement.txt`,
+   but all of the source code links to a newer, permissive license [0].
+   We have official, public confirmation [1], that the newer license applies.


Maybe adding a local copy of this statement to this repository?

rettichschnidi · 2023-05-13T08:14:47Z

si32/README

+
+  * Download precision32-development-environment-offline.exe
+  * run `./scripts/extract_hal /path/to/downloaded-file`
+  * The extracted HAL will be in `$CWD/tmp`, Copy the necessary directories


Suggested change

* The extracted HAL will be in `$CWD/tmp`, Copy the necessary directories

* The extracted HAL will be in `$CWD/tmp`, copy the necessary directories

nope. after a , you don't start with an uppercase character. Also, that sentence is gone now.

rettichschnidi · 2023-05-14T09:38:20Z

si32/README

+++++++++++++
+
+  * Download precision32-development-environment-offline.exe
+  * run `./scripts/extract_hal /path/to/downloaded-file`


It does not seem to work for me:

$ sha512sum ~/Downloads/precision32-development-environment-offline.exe 6bccef30995da803985fcdfa4065c45e00e0eeefc300d61b7215926a97997dc8ce45078ffeb349602340759650f30aeccf3b1aa50086c61edc2426d016063cae /home/reto/Downloads/precision32-development-environment-offline.exe $ scripts/extract_hal ~/Downloads/precision32-development-environment-offline.exe 7-Zip (a) [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21 p7zip Version 16.02 (locale=en_US.utf8,Utf16=on,HugeFiles=on,64 bits,32 CPUs AMD Ryzen 9 5900X 12-Core Processor (A20F10),ASM,AES-NI) Scanning the drive for archives: 1 file, 427228821 bytes (408 MiB) Extracting archive: /home/username/Downloads/precision32-development-environment-offline.exe ERRORS: Headers Error Unconfirmed start of archive WARNINGS: Headers Error There are data after the end of archive -- Path = /home/username/Downloads/precision32-development-environment-offline.exe Type = zip ERRORS: Headers Error Unconfirmed start of archive WARNINGS: Headers Error There are data after the end of archive Offset = 1815905 Physical Size = 271798 Tail Size = 425141118 No files to process Archives with Errors: 1 Warnings: 1 Open Errors: 1

Any ideas?

You're using 7zip 16.02 which was released in 2016. I'm using 17.04 which has support for lots of new file formats. (There's also 17.05 which got released recently which I haven't tested, yet).

I documented the version requirement.

rettichschnidi · 2023-05-14T09:42:06Z

si32/README

@@ -0,0 +1,50 @@
+Silicon Labs SI32 HAL


Suggested change

Silicon Labs SI32 HAL

Silicon Labs Si32 HAL

fkokosinski · 2023-05-15T08:15:04Z

si32/README

+   v1.1.2
+
+Purpose:
+   Add support for Silican Labs sim3u1xx SoCs


Suggested change

Add support for Silican Labs sim3u1xx SoCs

Add support for Silicon Labs sim3u1xx SoCs

fkokosinski · 2023-05-16T10:15:57Z

si32/si32Hal/CPU/core_cm3.h

+ * MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE APPLY TO THIS SOFTWARE.
+ * ARM SHALL NOT, IN ANY CIRCUMSTANCES, BE LIABLE FOR SPECIAL, INCIDENTAL, OR
+ * CONSEQUENTIAL DAMAGES, FOR ANY REASON WHATSOEVER.
+ *


Wrong license? Keep in mind that Zephyr accepts only OSI-compliant licenses for HAL source files.

These are actually not needed because zephyr provides them already and we can just use those instead.
But what makes a license OSI-compliant? Is the permissive Silicon Laboratories End User License Agreement still an issue?

See here for a list: https://opensource.org/licenses/

Okay that's unfortunate since it means that this okay is not enough.
@silabs-Joe Is it possible for you to allow us to change the license to z-lib(the same license as the gecko hal)?
We could change it ourselves so you don't have to put in any work, but we do obviously need the okay.

Hi @M1cha,
I am a Silicon Labs employee. I've checked with our legal team and they approve Gardena applying a ZLIB license to the code in the si32Hal folder for the Zephyr OS project. So you can adapt or modify the files to include the ZLIB license instead of the current license text.

Below is the ZLIB license text to use in the headers for the si32Hal folder:
Copyright 2012 (c) Silicon Laboratories Inc.

This siHAL software is provided 'as-is', without any express or implied warranty. In no event will the authors be held liable for any damages arising from the use of this software.

Permission is granted to anyone to use this software for any purpose, including commercial applications, and to alter it and redistribute it freely, subject to the following restrictions:

1. The origin of this software must not be misrepresented; you must not claim that you wrote the original software. If you use this software in a product, an acknowledgment in the product documentation would be appreciated but is not required.

2. Altered source versions must be plainly marked as such, and must not be misrepresented as being the original software.

3. This notice may not be removed or altered from any source distribution.

Please let me know if you have any questions.

Best regards,
Spurthi

It would good to include the SPDX license identifier as well so its easy to see the license type.

It would good to include the SPDX license identifier as well so its easy to see the license type.

Agreed. I think it would also make sense to include a signoff from @silabs-spurthi in the commit that adds the re-licensed files, and also describe that fact in the commit message. This would ensure that there is a trace of what happened in the commit history, and that this is not lost somewhere in the comment section on GH.

M1cha · 2023-07-13T04:54:48Z

I've done the following:

rebased to master
addressed all comments
added a copy_hal script which copies and patches the SDK
added a dump of this site in license-change-permit.html so the relicensing permit will not be lost.
I excluded the CMSIS headers since they had a proprietary license and we have a compatible version in modules/hal/cmsis.
I excluded startup and linker files since they had a proprietary license and we don't need them.

I did not add a SPDX license identifier since @silabs-spurthi never gave their ok for that.

silabs-Joe · 2023-08-09T22:10:39Z

@M1cha Our legal team has approved adding the SPDX license identifier.

rettichschnidi

LGTM. Will look even better with SPDX identifiers.

msierszulski · 2023-08-21T13:31:03Z

Hi @M1cha, as @silabs-Joe said:

@M1cha Our legal team has approved adding the SPDX license identifier.

Can you please add the SPDX license identifier? Remember the proper description as @fkokosinski said in his previous comment.

This was referenced May 13, 2023

sim3u167bgm SOC support zephyrproject-rtos/zephyr#55287

Open

SIM3U support zephyrproject-rtos/zephyr#57871

Closed

rettichschnidi suggested changes May 14, 2023

View reviewed changes

rettichschnidi reviewed May 14, 2023

View reviewed changes

fkokosinski requested changes May 16, 2023

View reviewed changes

M1cha force-pushed the sim3u branch 2 times, most recently from e6e2e11 to b0563af Compare July 13, 2023 04:50

M1cha force-pushed the sim3u branch from b0563af to 0102772 Compare July 13, 2023 04:56

add si32 HAL

49ac501

M1cha force-pushed the sim3u branch from 0102772 to 49ac501 Compare July 13, 2023 04:58

rettichschnidi approved these changes Aug 17, 2023

View reviewed changes

nashif assigned fkokosinski Aug 17, 2023

add si32 HAL #29

M1cha commented May 13, 2023

rettichschnidi May 13, 2023

M1cha Jul 13, 2023

rettichschnidi May 13, 2023

M1cha Jul 13, 2023

rettichschnidi May 13, 2023

M1cha May 14, 2023

rettichschnidi May 13, 2023

M1cha Jul 13, 2023

rettichschnidi May 14, 2023

M1cha May 14, 2023

M1cha Jul 13, 2023

rettichschnidi May 14, 2023

M1cha Jul 13, 2023

fkokosinski May 15, 2023

M1cha Jul 13, 2023

fkokosinski May 16, 2023

M1cha May 16, 2023

pgielda May 16, 2023

M1cha May 16, 2023

silabs-spurthi Jun 28, 2023

mmahadevan108 Jun 28, 2023

fkokosinski Jul 5, 2023

M1cha commented Jul 13, 2023

silabs-Joe commented Aug 9, 2023

rettichschnidi left a comment

msierszulski commented Aug 21, 2023

	Add support for Silican Labs sim3u1xx SoCs
	Add support for Silican Labs SiM3U1xx SoCs

	This code component is used to add Zephyr support for Silicon Labs sim3u1xx SoCs.
	This code component is used to add Zephyr support for Silicon Labs SiM3U1xx SoCs.

	* The extracted HAL will be in `$CWD/tmp`, Copy the necessary directories
	* The extracted HAL will be in `$CWD/tmp`, copy the necessary directories

	Add support for Silican Labs sim3u1xx SoCs
	Add support for Silicon Labs sim3u1xx SoCs

add si32 HAL #29

Are you sure you want to change the base?

Conversation

M1cha commented on May 13May 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

M1cha commented on Jul 13Jul 13, 2023

silabs-Joe commented 3 weeks agoAug 9, 2023

rettichschnidi left a comment

msierszulski commented last weekAug 21, 2023

M1cha commented May 13, 2023

M1cha commented Jul 13, 2023

silabs-Joe commented Aug 9, 2023

msierszulski commented Aug 21, 2023