Lines Matching refs:code
4 Why do we do code reviews?
7 The main goal of code reviews is to improve the code quality. By reviewing each
8 other's code, we can help catch issues that were missed by the author
14 community. People with more expertise in one area of the code base can
21 Overview of the code review process
28 Technical ownership of most parts of the codebase falls on the :ref:`code
50 To ensure the code review gives the greatest possible benefit, participants in
60 code review helps everyone in the long run, as it creates a culture of
77 In the event that a code review takes longer than you would hope for, you
83 - If one code owner has become unresponsive, ask the other code owners for
86 - If there is only one code owner and they have become unresponsive, ask one
89 - Do the right thing for the project, not the fastest thing to get code merged.
91 For example, if some existing piece of code - say a driver - does not quite
92 meet your exact needs, go the extra mile and extend the code with the missing
93 functionality you require - as opposed to copying the code into some other
119 Guidelines for code owners
122 Code owners are listed on the :ref:`Project Maintenance<code owners>` page,
125 When reviewing a patch, code owners are expected to check the following:
129 - The structure of the code is clear.
145 - (Only applicable to generic code) The code is MISRA-compliant (see
156 If a code owner is happy with a patch, they should give their approval
174 - Be mindful when reviewing a patch. As a code owner, you are viewed as
193 For example, platform code should be added under the ``plat/`` directory.
198 name clashes with generic code.
202 - Interaction of the patch with other modules in the code base.
211 - There is no third party code or binary blobs with potential IP concerns.
212 Maintainers should look for copyright or license notices in code, and use
216 - Generally speaking, new driver code should be placed in the generic
222 type of code duplication hurts the maintainability of the project. The