Lines Matching +full:files +full:- +full:exclude
2 # SPDX-License-Identifier: GPL-2.0
7 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
8 # (c) 2010-2018 Joe Perches <joe@perches.com>
52 my @exclude = ();
67 my $git_command ='export LANGUAGE=en_US.UTF-8; git';
78 -q, --quiet quiet
79 --no-tree run without a kernel tree
80 --no-signoff do not check for 'Signed-off-by' line
81 --patch treat FILE as patchfile (default)
82 --emacs emacs compile window format
83 --terse one line per report
84 --showfile emit diffed file position, not input file position
85 -g, --git treat FILE as a single commit or git revision range
93 <rev>-<count>
95 -f, --file treat FILE as regular source file
96 --subjective, --strict enable more subjective tests
97 --list-types list the possible message types
98 --types TYPE(,TYPE2...) show only these comma separated message types
99 --ignore TYPE(,TYPE2...) ignore various comma separated message types
100 --exclude DIR (--exclude DIR2...) exclude directories
101 --show-types show the specific message type in the output
102 --max-line-length=n set the maximum line length, (default $max_line_length)
104 requires --strict for use with --file
105 --min-conf-desc-length=n set the min description length, if shorter, warn
106 --tab-size=n set the number of spaces for tab (default $tabsize)
107 --root=PATH PATH to the kernel tree root
108 --no-summary suppress the per-file summary
109 --mailback only produce a report in case of warnings/errors
110 --summary-file include the filename in summary
111 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
114 --test-only=WORD report only warnings/errors containing WORD
116 --fix EXPERIMENTAL - may create horrible results
117 If correctable single-line errors exist, create
118 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
121 --fix-inplace EXPERIMENTAL - may create horrible results
122 Is the same as --fix, but overwrites the input
124 --ignore-perl-version override checking of perl version. expect
126 --codespell Use the codespell dictionary for spelling/typos
128 --codespellfile Use this codespell dictionary
129 --typedefsfile Read additional types from this file
130 --color[=WHEN] Use colors 'always', 'never', or only when output
132 -h, --help, --version display this help and exit
134 When FILE is - read standard input.
173 if (-f $conf) {
199 # Prevent --color by itself from consuming other arguments
201 if ($_ eq "--color" || $_ eq "-color") {
202 $_ = "--color=$color";
219 'exclude=s' => \@exclude,
221 'show-types!' => \$show_types,
222 'list-types!' => \$list_types,
223 'max-line-length=i' => \$max_line_length,
224 'min-conf-desc-length=i' => \$min_conf_desc_length,
225 'tab-size=i' => \$tabsize,
229 'summary-file!' => \$summary_file,
231 'fix-inplace!' => \$fix_inplace,
232 'ignore-perl-version!' => \$ignore_perl_version,
234 'test-only=s' => \$tst_only,
239 'no-color' => \$color, #keep old behaviors of -nocolor
240 'nocolor' => \$color, #keep old behaviors of -nocolor
252 die "$P: --git cannot be used with --file or --fix\n" if ($git && ($file || $fix));
263 #if no filenames are given, push '-' to read patch from stdin
265 push(@ARGV, '-');
275 $color = (-t STDOUT);
280 # skip TAB size 1 to avoid additional checks on $tabsize - 1
291 $word =~ tr/[a-z]/[A-Z]/;
296 $hashRef->{$word}++;
335 die "$P: $root: --root does not point at a valid tree\n";
347 print "Must be run from the top-level dir. of a kernel tree\n";
355 [A-Za-z_][A-Za-z\d_]*
356 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
408 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
413 our $Hex = qr{(?i)0x[0-9a-f]+$Int_type?};
414 our $Int = qr{[0-9]+$Int_type?};
415 our $Octal = qr{0[0-7]+$Int_type?};
417 our $Float_hex = qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
418 our $Float_dec = qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
419 our $Float_int = qr{(?i)[0-9]+e-?[0-9]+[fl]?};
422 our $Assignment = qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
423 our $Compare = qr{<=|>=|==|!=|<|(?<!-)>};
424 our $Arithmetic = qr{\+|-|\*|\/|%};
427 =>|->|<<|>>|<|>|!|~|
428 &&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
443 [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
444 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
445 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
446 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
447 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
448 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
449 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
453 [\x09\x0A\x0D\x20-\x7E] # ASCII
476 …(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|co…
480 MODULE_[A-Z_]+|
495 Signed-off-by:|
496 Co-authored-by:|
497 Co-developed-by:|
498 Acked-by:|
499 Tested-by:|
500 Reviewed-by:|
501 Reported-by:|
502 Suggested-by:|
589 ["IIO_DEV_ATTR_[A-Z_]+", 1],
595 my $word_pattern = '\b[A-Z]?[a-z]{2,}\b';
601 $mode_perms_search .= $entry->[0];
631 0[0-7][0-7][2367]
668 return trim($string) if ($string =~ /^\s*0[0-7]{3,3}\s*$/);
679 last if ($lastpos > 0 && ($curpos - length($omatch) != $lastpos));
719 warn "No typos will be found - file '$spelling_file': $!\n";
736 my ($suspect, $fix) = split(/->/, $line);
742 warn "No codespell typos will be found - file '$codespellfile': $!\n";
761 print("$file: '$line' invalid - ignored\n");
778 # or warn "No structs that should be const will be found - file '$conststructsfile': $!\n";
784 or warn "No additional types will be considered - file '$typedefsfile': $!\n";
844 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
849 (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
871 return if (!(-f $file));
883 next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
884 if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
886 } elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[\(\[,;]/) {
888 } elsif ($line =~ /^\s*(?:union|struct|enum)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[;\{]/) {
899 return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
902 …s{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback…
911 …return 1 if (!$tree || which("python") eq "" || !(-e "$root/scripts/spdxcheck.py") || !(-e "$root/…
914 my $status = `cd "$root_path"; echo "$license" | python scripts/spdxcheck.py -`;
923 my $files;
929 if (-e ".git") {
930 …my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include…
932 $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
935 $files = `find $root/include -name "*.h"`;
936 @include_files = split('\n', $files);
942 $camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
945 if ($camelcase_cache ne "" && -f $camelcase_cache) {
957 if (-e ".git") {
958 $files = `${git_command} ls-files "include/*.h"`;
959 @include_files = split('\n', $files);
967 unlink glob ".checkpatch-camelcase.*";
980 return ($id, $desc) if ((which("git") eq "") || !(-e ".git"));
982 my $output = `${git_command} log --no-color --format='%H %s' -1 $commit 2>&1`;
993 # git rev-list --remotes | grep -i "^$1" |
995 # git log --format='%H %s' -1 $line |
996 # echo "commit $(cut -c 1-12,41-)"
1015 my $fixlinenr = -1;
1018 # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
1019 die "$P: No git repository found\n" if ($git && !-e ".git");
1025 if ($commit_expr =~ m/^(.*)-(\d+)$/) {
1026 $git_range = "-$2 $1";
1030 $git_range = "-1 $commit_expr";
1032 my $lines = `${git_command} log --no-color --no-merges --pretty=format:'%H %s' $git_range`;
1034 $line =~ /^([0-9a-fA-F]{40,40}) (.*)$/;
1051 open($FILE, '-|', "git format-patch -M --stdout -1 $filename") ||
1052 die "$P: $filename: git format-patch failed - $!\n";
1054 open($FILE, '-|', "diff -u /dev/null $filename") ||
1055 die "$P: $filename: diff failed - $!\n";
1056 } elsif ($filename eq '-') {
1060 die "$P: $filename: open failed - $!\n";
1062 if ($filename eq '-') {
1072 $vname = qq("$1") if ($filename eq '-' && $_ =~ m/^Subject:\s+(.+)/i);
1077 print '-' x length($vname) . "\n";
1079 print '-' x length($vname) . "\n";
1090 $fixlinenr = -1;
1128 if (! -e $root . '/' . $check) {
1174 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1191 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1209 if (-e "$path/$bin") {
1221 if (-e "$path/$conf") {
1376 return substr($rawline, $-[0], $+[0] - $-[0]);
1381 my $line = $linenr - 1;
1384 my $coff = $off - 1;
1398 @stack = (['', 0]) if ($#stack == -1);
1406 next if ($lines[$line] =~ /^-/);
1407 $remain--;
1434 ($type, $level) = @{$stack[$#stack - 1]};
1450 $coff = $off + length($1) - 1;
1453 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1461 $level--;
1475 $level--;
1487 $level--;
1498 $remain--;
1501 my $statement = substr($blk, $soff, $off - $soff + 1);
1502 my $condition = substr($blk, $soff, $coff - $soff + 1);
1510 $line, $remain + 1, $off - $loff + 1, $level);
1567 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
1577 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
1588 my $start = $linenr - 1;
1597 next if ($rawlines[$line] =~ /^-/);
1598 $remain--;
1606 $level = $stack[$#stack - 1];
1614 $off--;
1619 $level--;
1668 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@^\+.*(//.*$)@);
1670 ($current_comment) = ($rawlines[$end_line - 2] =~ m@^[\+ ].*(//.*$)@);
1676 ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1684 my $line = $rawlines[$linenr - 1];
1708 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1717 my $offset = $linenr - 1;
1723 next if (defined($line) && $line =~ /^-/);
1724 $cnt--;
1894 print "PAREN('$1') -> $type\n"
1950 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1965 if ($1 ne '++' && $1 ne '--') {
2033 $type =~ tr/[a-z]/[A-Z]/;
2066 my @lines = split("\n", $output, -1);
2084 if ($$lineRef =~ /^\@\@ -\d+,\d+ \+(\d+),(\d+) \@\@/) {
2113 if ($line =~ /^(?:\+\+\+|\-\-\-)\s+\S+/) { #new filename
2115 } elsif ($line =~ /^\@\@ -\d+,\d+ \+\d+,\d+ \@\@/) { #new hunk
2123 fixup_current_range(\$lines[$range_last_linenr], $delta_offset--, -1);
2204 if (-f "$root/$file") {
2209 if (! -f _) {
2215 substr($prefix, -length($file)) = '';
2260 my $max_spaces_before_tab = $source_indent - 1;
2282 return -1;
2290 $pos += length($1) - 1;
2293 } elsif (index($string, '(') == -1) {
2320 my $is_binding_patch = -1;
2323 my $has_patch_separator = 0; #Found a --- line
2333 my $last_coalesced_string_linenr = -1;
2362 # Pre-scan the patch sanitizing the lines.
2363 # Pre-scan the patch looking for any __setup documentation.
2382 if ($1 =~ m@Documentation/admin-guide/kernel-parameters.txt$@) {
2387 if ($rawline =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
2388 $realline=$1-1;
2403 next if (defined $rawlines[$ln - 1] &&
2404 $rawlines[$ln - 1] =~ /^-/);
2405 $cnt--;
2406 #print "RAW<$rawlines[$ln - 1]>\n";
2407 last if (!defined $rawlines[$ln - 1]);
2408 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
2409 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
2432 # simplify matching -- only bother with positive lines.
2438 $realcnt-- if ($line =~ /^(?:\+| |$)/);
2444 #print "-->$line\n";
2455 $fixlinenr = -1;
2462 my $rawline = $rawlines[$linenr - 1];
2466 ($line =~ /^ mode change [0-7]+ => [0-7]+ \S+\s*$/ ||
2468 $line =~ /^diff --git a\/[\w\/\.\_\-]+ b\/\S+\s*$/))) {
2474 $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@(.*)/) {
2478 $realline=$1-1;
2503 $realcnt-- if ($realcnt != 0);
2516 $realcnt--;
2526 if ($line =~ /^diff --git.*?(\S+)$/) {
2538 -e "$root/$p1_prefix") {
2540 "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
2545 …"do not modify files in include/asm, change architecture specific files in include/asm-<architectu…
2550 foreach (@exclude) {
2585 $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
2587 if (($last_binding_patch != -1) &&
2590 …udes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
2613 "Missing commit description - Add an appropriate one\n");
2621 $line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
2622 $line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
2624 "Avoid using diff content in the commit message - patch(1) might not work\n" . $herecurr);
2634 "do not set execute permissions for source files\n" . $permhere);
2639 if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
2641 $author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);
2646 if ($line =~ /^\s*signed-off-by:/i) {
2652 if ($l =~ /^\s*signed-off-by:\s*\Q$author\E/i) {
2659 if ($line =~ /^---$/) {
2672 $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
2681 "Non-standard signature: $sign_off\n" . $herecurr);
2691 if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
2739 # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
2740 if ($sign_off =~ /^co-developed-by:$/i) {
2743 …"Co-developed-by: should not be used to attribute nominal patch author '$author'\n" . "$here\n" . …
2747 … "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
2748 } elsif ($rawlines[$linenr] !~ /^\s*signed-off-by:\s*(.*)/i) {
2750 …"Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" …
2753 …"Co-developed-by and Signed-off-by: name/email do not match \n" . "$here\n" . $rawline . "\n" .$ra…
2765 # Check for Gerrit Change-Ids not in any patch context
2766 if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
2768 "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr);
2776 $line =~ /^\s*\[\<[0-9a-fA-F]{8,}\>\]/) ||
2777 $line =~ /^(?:\s+\w+:\s+[0-9a-fA-F]+){3,3}/ ||
2778 $line =~ /^\s*\#\d+\s*\[[0-9a-fA-F]+\]\s*\w+ at [0-9a-fA-F]+/) {
2786 !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
2788 $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
2806 $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
2807 $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
2808 ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
2809 ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
2810 $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
2811 $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
2824 if ($line =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
2827 } elsif ($line =~ /\b([0-9a-f]{12,40})\b/i) {
2831 $short = 0 if ($line =~ /\bcommit\s+[0-9a-f]{12,40}/i);
2832 $long = 1 if ($line =~ /\bcommit\s+[0-9a-f]{41,}/i);
2833 $space = 0 if ($line =~ /\bcommit [0-9a-f]/i);
2834 $case = 0 if ($line =~ /\b[Cc]ommit\s+[0-9a-f]{5,40}[^A-F]/);
2835 if ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)"\)/i) {
2838 } elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s*$/i &&
2843 } elsif ($line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("[^"]+$/i &&
2846 $line =~ /\bcommit\s+[0-9a-f]{5,}\s+\("([^"]+)$/i;
2859 …it commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}omm…
2863 # Check for added, moved or deleted files
2866 $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
2867 ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
2880 … "DT bindings should be in DT schema format. See: Documentation/devicetree/writing-schema.rst\n");
2884 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
2890 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
2900 "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
2907 $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
2913 # Check if there is UTF-8 in a commit log when a mail header has explicitly
2916 $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
2917 $1 !~ /utf-8/i) {
2924 "8-bit UTF-8 used in possible commit log\n" . $herecurr);
2944 while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) {
2947 $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
2948 $typo_fix = uc($typo_fix) if ($typo =~ /^[A-Z]+$/);
2952 "'$typo' may be misspelled - perhaps '$typo_fix'?\n" . $herecurr) &&
2954 $fixed[$fixlinenr] =~ s/(^|[^A-Za-z@])($typo)($|[^A-Za-z@])/$1$typo_fix$3/;
2960 if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
2970 # ignore non-hunk lines and lines being removed
2971 next if (!$hunk_line || $line =~ /^-/);
3018 for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
3019 $f = $lines[$ln - 1];
3020 $cnt-- if ($lines[$ln - 1] !~ /^-/);
3021 $is_end = $lines[$ln - 1] =~ /^\+/;
3023 next if ($f =~ /^-/);
3026 if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
3028 } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
3029 $length = -1;
3058 if ($rawline =~ /^\+[A-Z]:/ &&
3059 $rawline !~ /^\+[A-Z]:\t\S/) {
3063 $fixed[$fixlinenr] =~ s/^(\+[A-Z]):\s*/$1:\t/;
3068 if ($rawline =~ /^\+[A-Z]:/ &&
3069 $prevrawline =~ /^[\+ ][A-Z]:/) {
3070 $rawline =~ /^\+([A-Z]):\s*(.*)/;
3073 $prevrawline =~ /^[\+ ]([A-Z]):\s*(.*)/;
3084 "Misordered MAINTAINERS entry - list '$cur:' before '$prev:'\n" . $hereprev);
3089 "Misordered MAINTAINERS entry - list file patterns in alphabetic order\n" . $hereprev);
3103 ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
3106 'EXTRA_AFLAGS' => 'asflags-y',
3107 'EXTRA_CFLAGS' => 'ccflags-y',
3108 'EXTRA_CPPFLAGS' => 'cppflags-y',
3109 'EXTRA_LDFLAGS' => 'ldflags-y',
3113 … of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacem…
3127 my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
3130 my $vp_file = $dt_path . "vendor-prefixes.txt";
3134 $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
3136 $compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
3137 `grep -Erq "$compat|$compat2|$compat3" $dt_path`;
3140 "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr);
3143 next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
3145 `grep -Eq "^$vendor\\b" $vp_file`;
3148 … "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
3153 # check for using SPDX license tag at beginning of files
3169 # check SPDX comment style for .[chsS] files
3171 $rawline =~ /SPDX-License-Identifier:/ &&
3178 $rawline !~ m@^\+\Q$comment\E SPDX-License-Identifier: @) {
3180 … "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
3181 } elsif ($rawline =~ /(SPDX-License-Identifier: .*)/) {
3188 not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
3193 "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) &&
3195 …$fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-…
3205 # check for using SPDX-License-Identifier on the wrong line number
3207 $rawline =~ /\bSPDX-License-Identifier:/ &&
3208 substr($line, @-, @+ - @-) eq "$;" x (@+ - @-)) {
3210 "Misplaced SPDX-License-Identifier tag - use line $checklicenseline instead\n" . $herecurr);
3237 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3252 } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\-]*:\/\/\S+/i) {
3259 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3264 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3287 # more than $tabsize must use tabs, except multi-line macros which may start
3375 # check multi-line statement indentation matches previous line
3483 $line =~ /^\+[a-z_]*init/ ||
3484 $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
3498 $last_blank_line != ($linenr - 1)) {
3554 # 4) empty lines in multi-line macros
3645 (!defined $lines[$realline_next - 1] ||
3646 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
3726 …if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[A-Z_]+|)FOR_EACH[A-Z_]+)\s*\(|do\b|else\b)/ && $li…
3733 "Too many leading tabs - consider code refactoring\n" . $herecurr);
3736 my $ctx_cnt = $realcnt - $#ctx - 1;
3743 defined $lines[$ctx_ln - 1] &&
3744 $lines[$ctx_ln - 1] =~ /^-/)) {
3746 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
3751 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
3753 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
3756 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
3760 defined $lines[$ctx_ln - 1])
3762 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
3766 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
3772 …if ($line =~ /\b(?:(?:if|while|for|(?:[A-Z_]+|)FOR_EACH[A-Z_]+)\s*\(|(?:do|else)\b)/ && $line !~ /…
3820 my $cond_ptr = -1;
3883 $prev_values = substr($curr_values, -1);
3889 if ($prevline =~ /^\+.*$Lval\s*(?:\.|->)\s*$/ &&
3891 $prevline =~ /($Lval\s*(?:\.|->))\s*$/;
3897 "Avoid multiple line dereference - prefer '$ref'\n" . $hereprev);
3953 fix_delete_line($fixlinenr - 1, $prevrawline);
3999 #print "APW <$lines[$realline_next - 1]>\n";
4001 exists $lines[$realline_next - 1] &&
4003 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
4004 $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
4010 if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
4023 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
4033 #print "FOO B <$lines[$linenr - 1]>\n";
4122 # check for non-global char *foo[] = {"bar", ...} declarations.
4145 "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&
4223 …"Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . …
4239 if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
4244 if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
4254 if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
4264 # number of false positives, but assembly files are not checked, so at
4310 fix_delete_line($fixlinenr - 1, $prevrawline);
4403 # 1. with a type on the left -- int [] a;
4404 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
4405 # 3. inside a curly brace -- = { [0...10] = 5 }
4407 my ($where, $prefix) = ($-[1], $1);
4424 my $ctx_before = substr($line, 0, $-[1]);
4434 # cpp #define statements have non-optional spaces, ie
4463 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
4464 =>|->|<<|>>|<|>|=|!|~|
4465 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
4486 my $last_after = -1;
4565 # ->
4566 } elsif ($op eq '->') {
4608 # '*' as part of a type definition -- reported already.
4616 $opv eq '*U' || $opv eq '-U' ||
4618 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
4641 # unary ++ and unary -- are allowed no space on one side.
4642 } elsif ($op eq '++' or $op eq '--') {
4672 $op eq '+' or $op eq '-' or
4774 # check for whitespace before a non-naked semicolon
4875 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
4887 # ie: (foo->bar)(); should be foo->bar();
4888 # but not "if (foo->bar) (" to avoid some false positives
4901 # when !drivers/staging or command-line uses --strict
4906 my $test = substr($2, 1, -1);
4930 if ($sline =~ /^.\s+[A-Za-z_][A-Za-z\d_]*:(?!\s*\d+)/ &&
4931 $sline !~ /^. [A-Za-z\d_][A-Za-z\d_]*:/ &&
4959 # at end-of-function, with the previous line a single leading tab, then return;
4964 $lines[$linenr - 3] =~ /^[ +]/ &&
4965 $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
4970 # if statements using unnecessary parentheses - ie: if ((foo == bar))
4978 $msg = " - maybe == should be = ?" if ($comp eq "==");
4989 $line =~ /^\+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) {
4996 $to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ &&
5014 if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
5018 "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
5032 # Check for illegal assignment in if conditional -- and check for trailing
5047 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
5049 statement_rawlines($whitespace) - 1;
5115 \s*0[xX][0-9]+\s*
5119 \s*0[xX][0-9]+\s*
5160 fix_delete_line($fixlinenr - 1, $prevrawline);
5186 fix_delete_line($fixlinenr - 1, $prevrawline);
5204 $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
5206 $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
5209 $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
5211 $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
5214 next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
5245 if (-f "$root/$checkfile" &&
5249 my $asminclude = `grep -Ec "#include\\s+<asm/$file>" $root/$checkfile`;
5262 # multi-statement macros should be enclosed in a do while loop, grab the
5277 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
5288 $define_args = substr($define_args, 1, length($define_args) - 2);
5335 $dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
5336 $dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
5337 …$dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // f…
5344 $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
5351 …"Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic d…
5354 … "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
5362 # Make $define_stmt single line, comment-free, etc
5390 "Macro argument reuse '$arg' - possible side-effects?\n" . "$herectx");
5424 # single-statement macros do not need to be enclosed in do while (0) loop,
5478 my $ln = $linenr - 1;
5483 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
5484 my $offset = statement_rawlines($whitespace) - 1;
5493 $ln += statement_rawlines($block) - 1;
5530 if (!defined $suppress_ifbraces{$linenr - 1} &&
5534 # Check the pre-context.
5535 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
5541 ctx_statement_full($linenr, $realcnt, $-[0]);
5561 # Check the post-context.
5568 #print "APW: ALLOWED: chunk-1 block<$block>\n";
5592 fix_delete_line($fixlinenr - 1, $prevrawline);
5607 …"Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . …
5610 # Check for user-visible strings broken across lines, which breaks the ability
5616 $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
5621 $last_coalesced_string_linenr != $linenr - 1) {
5628 fix_delete_line($fixlinenr - 1, $prevrawline);
5633 fix_insert_line($fixlinenr - 1, $fixedline);
5650 # This does not work very well for -f --file checking as it depends on patch
5651 # context providing the function name or a single line form for in-file
5672 if ($line =~ /$String[A-Za-z0-9_]/ || $line =~ /[A-Za-z0-9_]$String/) {
5677 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
5678 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E([A-Za-z0-9_])/$extracted_string $1/;
5679 $fixed[$fixlinenr] =~ s/([A-Za-z0-9_])\Q$extracted_string\E/$1 $extracted_string/;
5690 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
5691 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E\s*"/substr($extracted_string, 0, -1)/e;
5696 # check for non-standard and hex prefixed decimal printf formats
5700 my $string = substr($rawline, $-[1], $+[1] - $-[1]);
5705 "\%L$1 is non-standard C, use %ll$1\n" . $herecurr);
5711 "%Z$1 is non-standard C, use %z$1\n" . $herecurr);
5751 if ($lines[$linenr - 2] =~ /^\+(\t*)if\s*\(\s*$tested\s*\)\s*$/) {
5756 if ($lines[$linenr - 1] =~ /^\+(\t+)$func\s*\(\s*$tested\s*\)\s*;\s*$/) {
5765 fix_delete_line($fixlinenr - 1, $prevrawline);
5778 my $testline = $lines[$linenr - 3];
5780 my ($s, $c) = ctx_statement_block($linenr - 3, $realcnt, 0);
5792 $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
5812 … "Possible precedence defect with mask then right shift - may need parentheses\n" . $herecurr);
5876 # check for __read_mostly with const non-pointer (should just be const)
5905 … "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst\n" . $herecurr);
5909 "long udelay - prefer mdelay; see arch/arm/include/asm/delay.h\n" . $herecurr);
5917 …"msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst\n" . $herecurr);
5933 # warn about #ifdefs in C files
5935 # print "#ifdef in C files should be avoided\n";
5990 if ($realfile !~ m@^include/asm-generic/@ &&
5995 "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
6015 … m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
6070 my $old = substr($rawline, $-[1], $+[1] - $-[1]);
6071 my $new = substr($old, 1, -1);
6083 …"__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-ind…
6094 …"__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index…
6195 my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0));
6221 $use = " - use %pS instead";
6323 …"usleep_range should not use min == max args; see Documentation/timers/timers-howto.rst\n" . "$her…
6327 …"usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.rst\n" . "$he…
6363 # check for new externs in .h files.
6367 "extern prototypes should be avoided in .h files\n" . $herecurr) &&
6373 # check for new externs in .c files.
6387 "externs should be avoided in .c files\n" . $herecurr);
6399 "externs should be avoided in .c files\n" . $herecurr);
6445 …"__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.txt\n" . $here…
6452 … "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
6479 !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) {
6534 …if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(CONFIG_[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:\s*…
6566 "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr);
6578 "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
6659 …"usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_po…
6665 … "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);
6705 "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
6712 …"Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $…
6720 …E_ATTR\s*\(\s*(\w+)\s*,\s*\(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*\)?\s*…
6782 my $func = $entry->[0];
6783 my $arg_pos = $entry->[1];
6791 $arg_pos--;
6806 …"Exporting writable files is usually an error. Consider more restrictive permissions.\n" . "$here\…
6850 if ($#rawlines == -1) {
6860 # This is not a patch, and we are are in 'no-patch' mode so
6866 if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
6868 "Does not appear to be a unified-diff format patch\n");
6873 "Missing Signed-off-by: line(s)\n");
6876 "Missing Signed-off-by: line by nominal patch author '$author'\n");
6894 mechanically convert to the typical style using --fix or --fix-inplace.
6913 $newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace);
6937 Wrote EXPERIMENTAL --fix correction(s) to '$newfile'