Lines Matching +full:embedded +full:- +full:trace +full:- +full:extension
2 # SPDX-License-Identifier: GPL-2.0
7 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
8 # (c) 2010-2018 Joe Perches <joe@perches.com>
67 my $docsfile = "$D/../Documentation/dev-tools/checkpatch.rst";
70 my $allow_c99_comments = 1; # Can be overridden by --ignore C99_COMMENT_TOLERANCE
72 my $git_command ='export LANGUAGE=en_US.UTF-8; git';
84 -q, --quiet quiet
85 -v, --verbose verbose mode
86 --no-tree run without a kernel tree
87 --no-signoff do not check for 'Signed-off-by' line
88 --patch treat FILE as patchfile (default)
89 --emacs emacs compile window format
90 --terse one line per report
91 --showfile emit diffed file position, not input file position
92 -g, --git treat FILE as a single commit or git revision range
100 <rev>-<count>
102 -f, --file treat FILE as regular source file
103 --subjective, --strict enable more subjective tests
104 --list-types list the possible message types
105 --types TYPE(,TYPE2...) show only these comma separated message types
106 --ignore TYPE(,TYPE2...) ignore various comma separated message types
107 --show-types show the specific message type in the output
108 --max-line-length=n set the maximum line length, (default $max_line_length)
110 requires --strict for use with --file
111 --min-conf-desc-length=n set the min description length, if shorter, warn
112 --tab-size=n set the number of spaces for tab (default $tabsize)
113 --root=PATH PATH to the kernel tree root
114 --no-summary suppress the per-file summary
115 --mailback only produce a report in case of warnings/errors
116 --summary-file include the filename in summary
117 --debug KEY=[0|1] turn on/off debugging of KEY, where KEY is one of
120 --test-only=WORD report only warnings/errors containing WORD
122 --fix EXPERIMENTAL - may create horrible results
123 If correctable single-line errors exist, create
124 "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
127 --fix-inplace EXPERIMENTAL - may create horrible results
128 Is the same as --fix, but overwrites the input
130 --ignore-perl-version override checking of perl version. expect
132 --codespell Use the codespell dictionary for spelling/typos
134 --codespellfile Use this codespell dictionary
135 --typedefsfile Read additional types from this file
136 --color[=WHEN] Use colors 'always', 'never', or only when output
138 --kconfig-prefix=WORD use WORD as a prefix for Kconfig symbols (default
140 -h, --help, --version display this help and exit
142 When FILE is - read standard input.
217 if (-f $conf) {
283 # Prevent --color by itself from consuming other arguments
285 if ($_ eq "--color" || $_ eq "-color") {
286 $_ = "--color=$color";
305 'show-types!' => \$show_types,
306 'list-types!' => \$list_types,
307 'max-line-length=i' => \$max_line_length,
308 'min-conf-desc-length=i' => \$min_conf_desc_length,
309 'tab-size=i' => \$tabsize,
313 'summary-file!' => \$summary_file,
315 'fix-inplace!' => \$fix_inplace,
316 'ignore-perl-version!' => \$ignore_perl_version,
318 'test-only=s' => \$tst_only,
323 'no-color' => \$color, #keep old behaviors of -nocolor
324 'nocolor' => \$color, #keep old behaviors of -nocolor
325 'kconfig-prefix=s' => \${CONFIG_},
332 die "$P: --git cannot be used with --file or --fix\n" if ($git && ($file || $fix));
333 die "$P: --verbose cannot be used with --terse\n" if ($verbose && $terse);
342 $color = (-t STDOUT);
362 #if no filenames are given, push '-' to read patch from stdin
364 push(@ARGV, '-');
367 # skip TAB size 1 to avoid additional checks on $tabsize - 1
378 $word =~ tr/[a-z]/[A-Z]/;
383 $hashRef->{$word}++;
422 die "$P: $root: --root does not point at a valid tree\n";
434 print "Must be run from the top-level dir. of a kernel tree\n";
442 [A-Za-z_][A-Za-z\d_]*
443 (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
496 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
501 our $Hex = qr{(?i)0x[0-9a-f]+$Int_type?};
502 our $Int = qr{[0-9]+$Int_type?};
503 our $Octal = qr{0[0-7]+$Int_type?};
505 our $Float_hex = qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
506 our $Float_dec = qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
507 our $Float_int = qr{(?i)[0-9]+e-?[0-9]+[fl]?};
510 our $Assignment = qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
511 our $Compare = qr{<=|>=|==|!=|<|(?<!-)>};
512 our $Arithmetic = qr{\+|-|\*|\/|%};
515 =>|->|<<|>>|<|>|!|~|
516 &&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
531 [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
532 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
533 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
534 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
535 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
536 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
537 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
541 [\x09\x0A\x0D\x20-\x7E] # ASCII
564 …(?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|co…
568 MODULE_[A-Z_]+|
583 Signed-off-by:|
584 Co-developed-by:|
585 Acked-by:|
586 Tested-by:|
587 Reviewed-by:|
588 Reported-by:|
589 Suggested-by:|
595 [=-]*> |
596 <[=-]* |
626 for my $i (0 .. ($len-1)) {
638 $str1 =~ s/-//g;
639 $str2 =~ s/-//g;
650 } elsif (substr($str1, $i-1, 1) eq substr($str2, $j-1, 1)) {
651 $distance[$i][$j] = $distance[$i - 1][$j - 1];
653 my $dist1 = $distance[$i][$j - 1]; #insert distance
654 my $dist2 = $distance[$i - 1][$j]; # remove
655 my $dist3 = $distance[$i - 1][$j - 1]; #replace
666 'Signed-off-by:', 'Co-developed-by:', 'Acked-by:', 'Tested-by:',
667 'Reviewed-by:', 'Reported-by:', 'Suggested-by:'
758 ["IIO_DEV_ATTR_[A-Z_]+", 1],
764 my $word_pattern = '\b[A-Z]?[a-z]{2,}\b';
770 $mode_perms_search .= $entry->[0];
800 0[0-7][0-7][2367]
837 return trim($string) if ($string =~ /^\s*0[0-7]{3,3}\s*$/);
848 last if ($lastpos > 0 && ($curpos - length($omatch) != $lastpos));
888 warn "No typos will be found - file '$spelling_file': $!\n";
905 my ($suspect, $fix) = split(/->/, $line);
911 warn "No codespell typos will be found - file '$codespellfile': $!\n";
930 print("$file: '$line' invalid - ignored\n");
947 or warn "No structs that should be const will be found - file '$conststructsfile': $!\n";
953 or warn "No additional types will be considered - file '$typedefsfile': $!\n";
1013 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
1018 (?:$Storage\s+)?(?:[A-Z_][A-Z0-9]*_){0,2}(?:DEFINE|DECLARE)(?:_[A-Z0-9]+){1,6}\s*\(|
1047 return if (!(-f $file));
1059 next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
1060 if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
1062 } elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[\(\[,;]/) {
1064 } elsif ($line =~ /^\s*(?:union|struct|enum)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*[;\{]/) {
1075 return 0 if (!$tree || !(-e "$root/scripts/get_maintainer.pl"));
1078 …s{$filename} = `perl $root/scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback…
1087 …return 1 if (!$tree || which("python3") eq "" || !(-x "$root/scripts/spdxcheck.py") || !(-e "$gitr…
1090 my $status = `cd "$root_path"; echo "$license" | scripts/spdxcheck.py -`;
1105 if (-e "$gitroot") {
1106 …my $git_last_include_commit = `${git_command} log --no-merges --pretty=format:"%h%n" -1 -- include…
1108 $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
1111 $files = `find $root/include -name "*.h"`;
1118 $camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
1121 if ($camelcase_cache ne "" && -f $camelcase_cache) {
1133 if (-e "$gitroot") {
1134 $files = `${git_command} ls-files "include/*.h"`;
1143 unlink glob ".checkpatch-camelcase.*";
1156 return 0 if ((which("git") eq "") || !(-e "$gitroot"));
1158 my $output = `${git_command} ls-files -- $filename 2>/dev/null`;
1166 return ($id, $desc) if ((which("git") eq "") || !(-e "$gitroot"));
1168 my $output = `${git_command} log --no-color --format='%H %s' -1 $commit 2>&1`;
1179 # git rev-list --remotes | grep -i "^$1" |
1181 # git log --format='%H %s' -1 $line |
1182 # echo "commit $(cut -c 1-12,41-)"
1202 my $fixlinenr = -1;
1205 # For example, HEAD-3 means we need check 'HEAD, HEAD~1, HEAD~2'.
1206 die "$P: No git repository found\n" if ($git && !-e "$gitroot");
1212 if ($commit_expr =~ m/^(.*)-(\d+)$/) {
1213 $git_range = "-$2 $1";
1217 $git_range = "-1 $commit_expr";
1219 my $lines = `${git_command} log --no-color --no-merges --pretty=format:'%H %s' $git_range`;
1221 $line =~ /^([0-9a-fA-F]{40,40}) (.*)$/;
1241 open($FILE, '-|', "git format-patch -M --stdout -1 $filename") ||
1242 die "$P: $filename: git format-patch failed - $!\n";
1244 open($FILE, '-|', "diff -u /dev/null $filename") ||
1245 die "$P: $filename: diff failed - $!\n";
1246 } elsif ($filename eq '-') {
1250 die "$P: $filename: open failed - $!\n";
1252 if ($filename eq '-') {
1262 $vname = qq("$1") if ($filename eq '-' && $_ =~ m/^Subject:\s+(.+)/i);
1267 print '-' x length($vname) . "\n";
1269 print '-' x length($vname) . "\n";
1280 $fixlinenr = -1;
1319 if (! -e $root . '/' . $check) {
1363 # "John D. (Doe)" - Do not extract
1377 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1394 if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
1436 if (-e "$path/$bin") {
1448 if (-e "$path/$conf") {
1603 return substr($rawline, $-[0], $+[0] - $-[0]);
1608 my $line = $linenr - 1;
1611 my $coff = $off - 1;
1625 @stack = (['', 0]) if ($#stack == -1);
1633 next if ($lines[$line] =~ /^-/);
1634 $remain--;
1661 ($type, $level) = @{$stack[$#stack - 1]};
1677 $coff = $off + length($1) - 1;
1680 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
1688 $level--;
1702 $level--;
1714 $level--;
1725 $remain--;
1728 my $statement = substr($blk, $soff, $off - $soff + 1);
1729 my $condition = substr($blk, $soff, $coff - $soff + 1);
1737 $line, $remain + 1, $off - $loff + 1, $level);
1794 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
1804 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
1815 my $start = $linenr - 1;
1824 next if ($rawlines[$line] =~ /^-/);
1825 $remain--;
1833 $level = $stack[$#stack - 1];
1841 $off--;
1846 $level--;
1895 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@^\+.*(//.*$)@);
1897 ($current_comment) = ($rawlines[$end_line - 2] =~ m@^[\+ ].*(//.*$)@);
1903 ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1911 my $line = $rawlines[$linenr - 1];
1935 ##print "LINE: $rawlines[$end_line - 1 ]\n";
1944 my $offset = $linenr - 1;
1950 next if (defined($line) && $line =~ /^-/);
1951 $cnt--;
2121 print "PAREN('$1') -> $type\n"
2177 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
2192 if ($1 ne '++' && $1 ne '--') {
2260 $type =~ tr/[a-z]/[A-Z]/;
2293 my @lines = split("\n", $output, -1);
2320 if ($$lineRef =~ /^\@\@ -\d+,\d+ \+(\d+),(\d+) \@\@/) {
2349 if ($line =~ /^(?:\+\+\+|\-\-\-)\s+\S+/) { #new filename
2351 } elsif ($line =~ /^\@\@ -\d+,\d+ \+\d+,\d+ \@\@/) { #new hunk
2359 fixup_current_range(\$lines[$range_last_linenr], $delta_offset--, -1);
2440 if (-f "$root/$file") {
2445 if (! -f _) {
2451 substr($prefix, -length($file)) = '';
2496 my $max_spaces_before_tab = $source_indent - 1;
2518 return -1;
2526 $pos += length($1) - 1;
2529 } elsif (index($string, '(') == -1) {
2541 for my $i (0 .. (length($line) - 1)) {
2579 my $is_binding_patch = -1;
2582 my $has_patch_separator = 0; #Found a --- line
2591 my $last_git_commit_id_linenr = -1;
2594 my $last_coalesced_string_linenr = -1;
2602 # Trace the real file/line as we go.
2623 # Pre-scan the patch sanitizing the lines.
2624 # Pre-scan the patch looking for any __setup documentation.
2643 if ($1 =~ m@Documentation/admin-guide/kernel-parameters.txt$@) {
2648 if ($rawline =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
2649 $realline=$1-1;
2664 next if (defined $rawlines[$ln - 1] &&
2665 $rawlines[$ln - 1] =~ /^-/);
2666 $cnt--;
2667 #print "RAW<$rawlines[$ln - 1]>\n";
2668 last if (!defined $rawlines[$ln - 1]);
2669 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
2670 $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
2693 # simplify matching -- only bother with positive lines.
2699 $realcnt-- if ($line =~ /^(?:\+| |$)/);
2705 #print "-->$line\n";
2716 $fixlinenr = -1;
2723 my $rawline = $rawlines[$linenr - 1];
2728 ($line =~ /^ mode change [0-7]+ => [0-7]+ \S+\s*$/ ||
2730 $line =~ /^diff --git a\/[\w\/\.\_\-]+ b\/\S+\s*$/))) {
2736 $line =~ /^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@(.*)/) {
2740 $realline=$1-1;
2765 $realcnt-- if ($realcnt != 0);
2778 $realcnt--;
2788 if ($line =~ /^diff --git.*?(\S+)$/) {
2800 -e "$root/$p1_prefix") {
2802 "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
2807 …"do not modify files in include/asm, change architecture specific files in include/asm-<architectu…
2838 $is_binding_patch = () = $realfile =~ m@^(?:Documentation/devicetree/|include/dt-bindings/)@;
2840 if (($last_binding_patch != -1) &&
2843 …udes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst\n");
2866 "Missing commit description - Add an appropriate one\n");
2874 $line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
2875 $line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
2877 "Avoid using diff content in the commit message - patch(1) might not work\n" . $herecurr);
2892 if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {
2898 $author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);
2904 if ($line =~ /^\s*signed-off-by:\s*(.*)/i) {
2943 if ($line =~ /^---$/) {
2956 $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
2967 "Non-standard signature: $sign_off\n" . $herecurr);
2970 "Non-standard signature: '$sign_off' - perhaps '$suggested_signature'?\n" . $herecurr) &&
2984 if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
3048 $cur_name =~ s/[a-zA-Z\s\-\"]+//g;
3098 # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email
3099 if ($sign_off =~ /^co-developed-by:$/i) {
3102 …"Co-developed-by: should not be used to attribute nominal patch author '$author'\n" . "$here\n" . …
3106 … "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline);
3107 } elsif ($rawlines[$linenr] !~ /^\s*signed-off-by:\s*(.*)/i) {
3109 …"Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" …
3112 …"Co-developed-by and Signed-off-by: name/email do not match \n" . "$here\n" . $rawline . "\n" .$ra…
3124 # Check for Gerrit Change-Ids not in any patch context
3125 if ($realfile eq '' && !$has_patch_separator && $line =~ /^\s*change-id:/i) {
3127 "Remove Gerrit Change-Id's before submitting upstream\n" . $herecurr) &&
3138 $line =~ /^\s*\[\<[0-9a-fA-F]{8,}\>\]/) ||
3139 $line =~ /^(?:\s+\w+:\s+[0-9a-fA-F]+){3,3}/ ||
3140 $line =~ /^\s*\#\d+\s*\[[0-9a-fA-F]+\]\s*\w+ at [0-9a-fA-F]+/) {
3148 !($line =~ /^\s*[a-zA-Z0-9_\/\.]+\s+\|\s+\d+/ ||
3150 $line =~ /^\s*(?:[\w\.\-]+\/)++[\w\.\-]+:/ ||
3177 # commit <SHA-1 hash length 12+ chars> ("Complete commit subject")
3180 # bare SHA-1 hash with minimum length of 5. It also avoids several types of
3181 # possible SHA-1 matches.
3186 $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
3187 $line !~ /^This reverts commit [0-9a-f]{7,40}/ &&
3188 (($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i ||
3189 … /\bcommit\s*$/i && defined($rawlines[$linenr]) && $rawlines[$linenr] =~ /^\s*[0-9a-f]{5,}\b/i)) ||
3190 ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
3191 $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i &&
3192 $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) {
3207 if ($line =~ /(?:\bcommit\s+[0-9a-f]{5,}|\bcommit\s*$)/i) {
3209 if ($input =~ /\bcommit\s+[0-9a-f]{5,}\s*($balanced_parens)/i) {
3213 $orig_desc = substr($orig_desc, 1, -1);
3215 $orig_desc = substr($orig_desc, 1, -1);
3227 if ($input =~ /\b(c)ommit\s+([0-9a-f]{5,})\b/i) {
3230 $short = 0 if ($input =~ /\bcommit\s+[0-9a-f]{12,40}/i);
3231 $long = 1 if ($input =~ /\bcommit\s+[0-9a-f]{41,}/i);
3232 $space = 0 if ($input =~ /\bcommit [0-9a-f]/i);
3233 $case = 0 if ($input =~ /\b[Cc]ommit\s+[0-9a-f]{5,40}[^A-F]/);
3234 } elsif ($input =~ /\b([0-9a-f]{12,40})\b/i) {
3243 $last_git_commit_id_linenr != $linenr - 1) {
3245 …it commit description style 'commit <12+ chars of sha1> (\"<title line>\")' - ie: '${init_char}omm…
3254 $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
3255 ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
3268 …"DT bindings should be in DT schema format. See: Documentation/devicetree/bindings/writing-schema.…
3272 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
3278 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
3288 "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
3295 $rawline =~ /^(?:commit\b|from\b|[\w-]+:)/i)) {
3301 # Check if there is UTF-8 in a commit log when a mail header has explicitly
3304 $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
3305 $1 !~ /utf-8/i) {
3312 "8-bit UTF-8 used in possible commit log\n" . $herecurr);
3332 while ($rawline =~ /(?:^|[^\w\-'`])($misspellings)(?:[^\w\-'`]|$)/gi) {
3335 my $ptr = substr($blank, 0, $-[1]) . "^" x length($typo);
3338 $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/);
3339 $typo_fix = uc($typo_fix) if ($typo =~ /^[A-Z]+$/);
3343 "'$typo' may be misspelled - perhaps '$typo_fix'?\n" . $hereptr) &&
3345 $fixed[$fixlinenr] =~ s/(^|[^A-Za-z@])($typo)($|[^A-Za-z@])/$1$typo_fix$3/;
3351 if ($in_commit_log && $line =~ /(^fixes:|\bcommit)\s+([0-9a-f]{6,40})\b/i) {
3362 # avoid false positive from list command eg, '-rw-r--r-- 1 root root'
3364 $rawline !~ /[bcCdDlMnpPs\?-][rwxsStT-]{9}/) {
3370 my $start_pos = $-[1];
3383 $start_char = substr($rawline, $start_pos - 1, 1) if ($start_pos > ($in_commit_log ? 0 : 1));
3387 next if (index(" \t.,;?!", $end_char) == -1);
3390 if ($first =~ /\b[0-9a-f]{2,}\b/i) {
3415 # ignore non-hunk lines and lines being removed
3416 next if (!$hunk_line || $line =~ /^-/);
3463 for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
3464 $f = $lines[$ln - 1];
3465 $cnt-- if ($lines[$ln - 1] !~ /^-/);
3466 $is_end = $lines[$ln - 1] =~ /^\+/;
3468 next if ($f =~ /^-/);
3471 if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
3473 } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
3474 $length = -1;
3503 if ($rawline =~ /^\+[A-Z]:/ &&
3504 $rawline !~ /^\+[A-Z]:\t\S/) {
3508 $fixed[$fixlinenr] =~ s/^(\+[A-Z]):\s*/$1:\t/;
3513 if ($rawline =~ /^\+[A-Z]:/ &&
3514 $prevrawline =~ /^[\+ ][A-Z]:/) {
3515 $rawline =~ /^\+([A-Z]):\s*(.*)/;
3518 $prevrawline =~ /^[\+ ]([A-Z]):\s*(.*)/;
3529 "Misordered MAINTAINERS entry - list '$cur:' before '$prev:'\n" . $hereprev);
3534 "Misordered MAINTAINERS entry - list file patterns in alphabetic order\n" . $hereprev);
3541 ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
3544 'EXTRA_AFLAGS' => 'asflags-y',
3545 'EXTRA_CFLAGS' => 'ccflags-y',
3546 'EXTRA_CPPFLAGS' => 'cppflags-y',
3547 'EXTRA_LDFLAGS' => 'ldflags-y',
3551 … of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacem…
3559 my @compats = $rawline =~ /\"([a-zA-Z0-9\-\,\.\+_]+)\"/g;
3562 my $vp_file = $dt_path . "vendor-prefixes.yaml";
3566 $compat2 =~ s/\,[a-zA-Z0-9]*\-/\,<\.\*>\-/;
3568 $compat3 =~ s/\,([a-z]*)[0-9]*\-/\,$1<\.\*>\-/;
3569 `grep -Erq "$compat|$compat2|$compat3" $dt_path`;
3572 "DT compatible string \"$compat\" appears un-documented -- check $dt_path\n" . $herecurr);
3575 next if $compat !~ /^([a-zA-Z0-9\-]+)\,/;
3577 `grep -Eq "\\"\\^\Q$vendor\E,\\.\\*\\":" $vp_file`;
3580 … "DT compatible string vendor \"$vendor\" appears un-documented -- check $vp_file\n" . $herecurr);
3603 $rawline =~ /SPDX-License-Identifier:/ &&
3610 $rawline !~ m@^\+\Q$comment\E SPDX-License-Identifier: @) {
3612 … "Missing or malformed SPDX-License-Identifier tag in line $checklicenseline\n" . $herecurr);
3613 } elsif ($rawline =~ /(SPDX-License-Identifier: .*)/) {
3620 not $spdx_license =~ /GPL-2\.0.*BSD-2-Clause/) {
3625 "DT binding documents should be licensed (GPL-2.0-only OR BSD-2-Clause)\n" . $herecurr) &&
3627 …$fixed[$fixlinenr] =~ s/SPDX-License-Identifier: .*/SPDX-License-Identifier: (GPL-2.0-only OR BSD-…
3634 # check for embedded filenames
3643 # check for using SPDX-License-Identifier on the wrong line number
3645 $rawline =~ /\bSPDX-License-Identifier:/ &&
3646 substr($line, @-, @+ - @-) eq "$;" x (@+ - @-)) {
3648 "Misplaced SPDX-License-Identifier tag - use line $checklicenseline instead\n" . $herecurr);
3675 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3690 } elsif ($rawline =~ /^\+.*\b[a-z][\w\.\+\-]*:\/\/\S+/i) {
3697 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3702 length(expand_tabs(substr($line, 1, length($line) - length($1) - 1))) <= $max_line_length) {
3726 $line =~ /^\+\s*(?:[A-Z]+_)?SYM_[A-Z]+_(?:START|END)(?:_[A-Z_]+)?\s*\(\s*\.L/) {
3728 …ing a range of code via 'SYM_*_START/END' annotations; see Documentation/asm-annotations.rst\n" . …
3767 $fixed[$fixlinenr - 1] .= " $operator";
3778 # insert logical operator at last non-comment, non-whitepsace char on previous line
3780 my $line_end = substr($prevrawline, $-[0]);
3781 $fixed[$fixlinenr - 1] =~ s/\Q$line_end\E$/ $operator$line_end/;
3799 # check multi-line statement indentation matches previous line
3851 …$realline > 3) { # Do not warn about the initial copyright comment block after SPDX-License-Identi…
3907 $line =~ /^\+[a-z_]*init/ ||
3908 $line =~ /^\+\s*(?:static\s+)?[A-Z_]*ATTR/ ||
3922 $last_blank_line != ($linenr - 1)) {
4076 (!defined $lines[$realline_next - 1] ||
4077 substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
4157 …if ($line =~ /(.*)\b((?:if|while|for|switch|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|do\b|else\b)/ && $li…
4164 "Too many leading tabs - consider code refactoring\n" . $herecurr);
4167 my $ctx_cnt = $realcnt - $#ctx - 1;
4174 defined $lines[$ctx_ln - 1] &&
4175 $lines[$ctx_ln - 1] =~ /^-/)) {
4177 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
4182 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
4184 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln - 1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
4187 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
4191 defined $lines[$ctx_ln - 1])
4193 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
4197 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
4203 …if ($line =~ /\b(?:(?:if|while|for|(?:[a-z_]+|)for_each[a-z_]+)\s*\(|(?:do|else)\b)/ && $line !~ /…
4251 my $cond_ptr = -1;
4314 $prev_values = substr($curr_values, -1);
4322 if ($line =~ /^\+\s*(?:$Declare)?([A-Za-z_][A-Za-z\d_]*)\s*=/) {
4326 "Do not use self-assignments to avoid compiler warnings\n" . $herecurr);
4331 if ($prevline =~ /^\+.*$Lval\s*(?:\.|->)\s*$/ &&
4333 $prevline =~ /($Lval\s*(?:\.|->))\s*$/;
4339 "Avoid multiple line dereference - prefer '$ref'\n" . $hereprev);
4395 fix_delete_line($fixlinenr - 1, $prevrawline);
4441 #print "APW <$lines[$realline_next - 1]>\n";
4443 exists $lines[$realline_next - 1] &&
4445 ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/)) {
4451 if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
4464 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
4473 #print "FOO B <$lines[$linenr - 1]>\n";
4568 "Move const after static - use 'static const $1'\n" . $herecurr) &&
4575 # check for non-global char *foo[] = {"bar", ...} declarations.
4598 "Bad function definition - $1() should probably be $1(void)\n" . $herecurr) &&
4676 …"Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()\n" . …
4692 if ($line =~ /\bprintk\s*\(\s*(?!KERN_[A-Z]+\b)/) {
4698 if ($line =~ /\b(printk(_once|_ratelimited)?)\s*\(\s*KERN_([A-Z]+)/) {
4714 if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
4776 fix_delete_line($fixlinenr - 1, $prevrawline);
4869 # 1. with a type on the left -- int [] a;
4870 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
4871 # 3. inside a curly brace -- = { [0...10] = 5 }
4873 my ($where, $prefix) = ($-[1], $1);
4889 my $ctx_before = substr($line, 0, $-[1]);
4899 # cpp #define statements have non-optional spaces, ie
4928 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
4929 =>|->|<<|>>|<|>|=|!|~|
4930 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
4951 my $last_after = -1;
5030 # ->
5031 } elsif ($op eq '->') {
5073 # '*' as part of a type definition -- reported already.
5081 $opv eq '*U' || $opv eq '-U' ||
5083 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
5106 # unary ++ and unary -- are allowed no space on one side.
5107 } elsif ($op eq '++' or $op eq '--') {
5137 $op eq '+' or $op eq '-' or
5232 # check for whitespace before a non-naked semicolon
5333 # ie: &(foo->bar) should be &foo->bar and *(foo->bar) should be *foo->bar
5345 # ie: (foo->bar)(); should be foo->bar();
5346 # but not "if (foo->bar) (" to avoid some false positives
5359 # when !drivers/staging or command-line uses --strict
5364 my $test = substr($2, 1, -1);
5388 if ($sline =~ /^.\s+[A-Za-z_][A-Za-z\d_]*:(?!\s*\d+)/ &&
5389 $sline !~ /^. [A-Za-z\d_][A-Za-z\d_]*:/ &&
5428 # at end-of-function, with the previous line a single leading tab, then return;
5433 $lines[$linenr - 3] =~ /^[ +]/ &&
5434 $lines[$linenr - 3] !~ /^[ +]\s*$Ident\s*:/) {
5439 # if statements using unnecessary parentheses - ie: if ((foo == bar))
5447 $msg = " - maybe == should be = ?" if ($comp eq "==");
5458 $line =~ /^\+(.*)\b($Constant|[A-Z_][A-Z0-9_]*)\s*($Compare)\s*($LvalOrFunc)/) {
5465 $to !~ /^(?:Constant|[A-Z_][A-Z0-9_]*)$/ &&
5483 if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) {
5487 "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr);
5501 # Check for illegal assignment in if conditional -- and check for trailing
5516 ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
5518 statement_rawlines($whitespace) - 1;
5584 \s*0[xX][0-9]+\s*
5588 \s*0[xX][0-9]+\s*
5629 fix_delete_line($fixlinenr - 1, $prevrawline);
5655 fix_delete_line($fixlinenr - 1, $prevrawline);
5673 $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
5675 $var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
5677 $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
5680 $var !~ /^(?:[a-z0-9_]*|[A-Z0-9_]*)?_?[a-z][A-Z](?:_[a-z0-9_]+|_[A-Z0-9_]+)?$/ &&
5682 $var !~ /^(?:[a-z_]*?)_?(?:[KMGT]iB|[KMGT]?Hz)(?:_[a-z_]+)?$/) {
5685 next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
5716 if (-f "$root/$checkfile" &&
5720 my $asminclude = `grep -Ec "#include\\s+<asm/$file>" $root/$checkfile`;
5733 # multi-statement macros should be enclosed in a do while loop, grab the
5748 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
5759 $define_args = substr($define_args, 1, length($define_args) - 2);
5806 $dstat !~ /^(?:$Ident|-?$Constant),$/ && # 10, // foo(),
5807 $dstat !~ /^(?:$Ident|-?$Constant);$/ && # foo();
5808 …$dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ && # 10 // foo() // !foo // ~foo // -foo // foo->bar // f…
5816 $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ && # for (...) bar()
5823 …"Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic d…
5826 … "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
5834 # Make $define_stmt single line, comment-free, etc
5862 "Macro argument reuse '$arg' - possible side-effects?\n" . "$herectx");
5896 # single-statement macros do not need to be enclosed in do while (0) loop,
5950 my $ln = $linenr - 1;
5955 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
5956 my $offset = statement_rawlines($whitespace) - 1;
5965 $ln += statement_rawlines($block) - 1;
6002 if (!defined $suppress_ifbraces{$linenr - 1} &&
6006 # Check the pre-context.
6007 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
6013 ctx_statement_full($linenr, $realcnt, $-[0]);
6033 # Check the post-context.
6040 #print "APW: ALLOWED: chunk-1 block<$block>\n";
6064 fix_delete_line($fixlinenr - 1, $prevrawline);
6079 …"Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rst\n" . …
6082 # Check for user-visible strings broken across lines, which breaks the ability
6088 $prevrawline !~ /(?:\\(?:[ntr]|[0-7]{1,3}|x[0-9a-fA-F]{1,2})|;\s*|\{\s*)"\s*$/) {
6093 $last_coalesced_string_linenr != $linenr - 1) {
6100 fix_delete_line($fixlinenr - 1, $prevrawline);
6105 fix_insert_line($fixlinenr - 1, $fixedline);
6121 # check for an embedded function name in a string when the function is known
6122 # This does not work very well for -f --file checking as it depends on patch
6123 # context providing the function name or a single line form for in-file
6138 "Unnecessary ftrace-like logging - prefer using ftrace\n" . $herecurr) &&
6155 if ($line =~ /$String[A-Z_]/ ||
6156 ($line =~ /([A-Za-z0-9_]+)$String/ && $1 !~ /^[Lu]$/)) {
6161 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
6162 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E([A-Za-z0-9_])/$extracted_string $1/;
6163 $fixed[$fixlinenr] =~ s/([A-Za-z0-9_])\Q$extracted_string\E/$1 $extracted_string/;
6174 my $extracted_string = substr($rawline, $-[0], $+[0] - $-[0]);
6175 $fixed[$fixlinenr] =~ s/\Q$extracted_string\E\s*"/substr($extracted_string, 0, -1)/e;
6180 # check for non-standard and hex prefixed decimal printf formats
6184 my $string = substr($rawline, $-[1], $+[1] - $-[1]);
6189 "\%L$1 is non-standard C, use %ll$1\n" . $herecurr);
6195 "%Z$1 is non-standard C, use %z$1\n" . $herecurr);
6235 if ($lines[$linenr - 2] =~ /^\+(\t*)if\s*\(\s*$tested\s*\)\s*$/) {
6240 if ($lines[$linenr - 1] =~ /^\+(\t+)$func\s*\(\s*$tested\s*\)\s*;\s*$/) {
6249 fix_delete_line($fixlinenr - 1, $prevrawline);
6262 my $testline = $lines[$linenr - 3];
6264 my ($s, $c) = ctx_statement_block($linenr - 3, $realcnt, 0);
6276 $line =~ /\b$logFunctions\s*\(.*\b(KERN_[A-Z]+)\b/) {
6299 while ($stat_real =~ /[^\"%]*(%[\#\d\.\*\-]*(h+)[idux])/g) {
6302 my $lineoff = substr($stat_real, 0, $-[1]) =~ tr@\n@@;
6318 … "Possible precedence defect with mask then right shift - may need parentheses\n" . $herecurr);
6382 # check for __read_mostly with const non-pointer (should just be const)
6411 … "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst\n" . $herecurr);
6415 "long udelay - prefer mdelay; see arch/arm/include/asm/delay.h\n" . $herecurr);
6423 …"msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst\n" . $herecurr);
6496 if ($realfile !~ m@^include/asm-generic/@ &&
6501 "__smp memory barriers shouldn't be used outside barrier.h and asm-generic\n" . $herecurr);
6521 … m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
6666 …"Unnecessary typecast of c90 int constant - '$cast$const' could be '$const$suffix'\n" . $herecurr)…
6706 # check for vsprintf extension %p<foo> misuses
6717 my $extension;
6720 my $fmt = get_quoted_string($lines[$count - 1], raw_line($count, 0));
6725 $extension = $2;
6727 if ($extension !~ /[4SsBKRraEehMmIiUDdgVCbGNOxtf]/ ||
6728 ($extension eq "f" &&
6730 ($extension eq "4" &&
6735 if ($extension eq "x" && !defined($stat_real)) {
6748 $use = " - use %pS instead";
6753 "$ext_type vsprintf pointer extension '$bad_specifier'$use\n" . "$here\n$stat_real\n");
6821 …"Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V…
6856 …"usleep_range should not use min == max args; see Documentation/timers/timers-howto.rst\n" . "$her…
6860 …"usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.rst\n" . "$he…
6978 …"__setup appears un-documented -- check Documentation/admin-guide/kernel-parameters.txt\n" . $here…
6985 … "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
7012 !($r1 =~ /^$Constant$/ || $r1 =~ /^[A-Z_][A-Z0-9_]*$/)) {
7067 …if ($line =~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(${CONFIG_}[A-Z_]+)\s*\)?\s*\|\|\s*defined(?:…
7080 'lint -fallthrough[ \t]*',
7081 'intentional(?:ly)?[ \t]*fall(?:(?:s | |-)[Tt]|t)hr(?:ough|u|ew)',
7082 '(?:else,?\s*)?FALL(?:S | |-)?THR(?:OUGH|U|EW)[ \t.!]*(?:-[^\n\r]*)?',
7083 'Fall(?:(?:s | |-)[Tt]|t)hr(?:ough|u|ew)[ \t.!]*(?:-[^\n\r]*)?',
7084 'fall(?:s | |-)?thr(?:ough|u|ew)[ \t.!]*(?:-[^\n\r]*)?',
7121 "Use of the '$1' macro makes the build non-deterministic\n" . $herecurr);
7127 "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n" . $herecurr);
7210 …"usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_po…
7216 … "#define of '$1' is wrong - use Kconfig variables or standard guards instead\n" . $herecurr);
7228 substr($rawline, $-[6], $+[6] - $-[6]) !~ /\\n"$/) {
7229 my $offset = $+[6] - 1;
7261 "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
7276 …E_ATTR\s*\(\s*(\w+)\s*,\s*\(?\s*(\s*(?:${multi_mode_perms_string_search}|0[0-7]{3,3})\s*)\s*\)?\s*…
7338 my $func = $entry->[0];
7339 my $arg_pos = $entry->[1];
7347 $arg_pos--;
7406 if ($#rawlines == -1) {
7416 # This is not a patch, and we are in 'no-patch' mode so
7422 if (!$is_patch && $filename !~ /cover-letter\.patch$/) {
7424 "Does not appear to be a unified-diff format patch\n");
7429 "Missing Signed-off-by: line(s)\n");
7432 # 0 -> missing sign off
7433 # 1 -> sign off identical
7434 # 2 -> names and addresses match, comments mismatch
7435 # 3 -> addresses match, names different
7436 # 4 -> names match, addresses different
7437 # 5 -> names match, addresses excluding subaddress details (refer RFC 5233) match
7439 my $sob_msg = "'From: $author' != 'Signed-off-by: $author_sob'";
7443 "Missing Signed-off-by: line by nominal patch author '$author'\n");
7446 "From:/Signed-off-by: email comments mismatch: $sob_msg\n");
7449 "From:/Signed-off-by: email name mismatch: $sob_msg\n");
7452 "From:/Signed-off-by: email address mismatch: $sob_msg\n");
7455 "From:/Signed-off-by: email subaddress mismatch: $sob_msg\n");
7474 mechanically convert to the typical style using --fix or --fix-inplace.
7493 $newfile .= ".EXPERIMENTAL-checkpatch-fixes" if (!$fix_inplace);
7517 Wrote EXPERIMENTAL --fix correction(s) to '$newfile'